Bug 168163

Summary: [GTK][EFL] Implement MIMETypeRegistry::getPreferredExtensionForMIMEType
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168193
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-02-11 00:46:05 PST
It's missing causing several HTML anchor download tests to fail because the suggested filename missed the extension.
Attachments
Patch (5.13 KB, patch)
2017-02-11 00:49 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-11 00:49:34 PST
Created attachment 301248 [details] Patch
Michael Catanzaro
Comment 2 2017-02-11 06:28:12 PST
Comment on attachment 301248 [details] Patch r=me but I'm not happy about the code duplication between MIMETypeRegistryEfl.cpp and MIMETypeRegistryGtk.cpp. Normally that means EFL gets an older and buggier version of our code for no good reason, but in this case it looks like the opposite is true, since EFL has more MIME types than us in its map. This should really be refactored into MIMETypeRegistryGeneric.cpp, which would be easy.
Carlos Garcia Campos
Comment 3 2017-02-11 06:31:39 PST
Committed r212192: <http://trac.webkit.org/changeset/212192>
Michael Catanzaro
Comment 4 2017-02-12 11:08:20 PST
It broke TestDownloads: bug #168193
Note You need to log in before you can comment on or make changes to this bug.