Bug 168163 - [GTK][EFL] Implement MIMETypeRegistry::getPreferredExtensionForMIMEType
Summary: [GTK][EFL] Implement MIMETypeRegistry::getPreferredExtensionForMIMEType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2017-02-11 00:46 PST by Carlos Garcia Campos
Modified: 2017-02-12 11:08 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2017-02-11 00:49 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-11 00:46:05 PST 
It's missing causing several HTML anchor download tests to fail because the suggested filename missed the extension.
Comment 1 Carlos Garcia Campos 2017-02-11 00:49:34 PST 
Created attachment 301248 [details]
Patch
Comment 2 Michael Catanzaro 2017-02-11 06:28:12 PST 
Comment on attachment 301248 [details]
Patch

r=me but I'm not happy about the code duplication between MIMETypeRegistryEfl.cpp and MIMETypeRegistryGtk.cpp. Normally that means EFL gets an older and buggier version of our code for no good reason, but in this case it looks like the opposite is true, since EFL has more MIME types than us in its map. This should really be refactored into MIMETypeRegistryGeneric.cpp, which would be easy.
Comment 3 Carlos Garcia Campos 2017-02-11 06:31:39 PST 
Committed r212192: <http://trac.webkit.org/changeset/212192>
Comment 4 Michael Catanzaro 2017-02-12 11:08:20 PST 
It broke TestDownloads: bug #168193