Bug 168159

Summary:

[WK2] Add test infrastructure and unit tests for data interaction

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit2

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Build fix	none
Add another test case	thorton: review+
Patch for landing	commit-queue: commit-queue-
Patch for landing	none

Wenson Hsieh

Reported 2017-02-10 19:30:38 PST

Build infrastructure to be able to test data interaction.

Attachments
Patch (47.14 KB, patch) 2017-02-10 20:17 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Build fix (47.43 KB, patch) 2017-02-10 20:47 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Add another test case (51.53 KB, patch) 2017-02-12 16:29 PST, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Patch for landing (51.55 KB, patch) 2017-02-13 14:40 PST, Wenson Hsieh	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (51.68 KB, patch) 2017-02-13 14:48 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-02-10 19:31:27 PST

<rdar://problem/30477634>

Wenson Hsieh

Comment 2 2017-02-10 20:17:39 PST

Created attachment 301239 [details] Patch

Wenson Hsieh

Comment 3 2017-02-10 20:47:38 PST

Created attachment 301242 [details] Build fix

Wenson Hsieh

Comment 4 2017-02-12 16:29:26 PST

Created attachment 301323 [details] Add another test case

Tim Horton

Comment 5 2017-02-13 12:38:04 PST

Comment on attachment 301323 [details] Add another test case View in context: https://bugs.webkit.org/attachment.cgi?id=301323&action=review > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:57 > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; ADOPT > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:70 > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; ADOPT > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:84 > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; ADOPT

Wenson Hsieh

Comment 6 2017-02-13 14:40:49 PST

Created attachment 301391 [details] Patch for landing

Wenson Hsieh

Comment 7 2017-02-13 14:41:20 PST

(In reply to comment #5) > Comment on attachment 301323 [details] > Add another test case > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301323&action=review > > > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:57 > > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; > > ADOPT Whoops, good catch. Fixed! > > > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:70 > > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; > > ADOPT > > > Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm:84 > > + RetainPtr<DataInteractionSimulator> dataInteractionSimulator = [[DataInteractionSimulator alloc] initWithWebView:webView.get() startLocation:CGPointMake(100, 100) endLocation:CGPointMake(100, 300)]; > > ADOPT

WebKit Commit Bot

Comment 8 2017-02-13 14:43:04 PST

Comment on attachment 301391 [details] Patch for landing Rejecting attachment 301391 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 301391, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: bKit2Cocoa/image-and-contenteditable.html patching file Tools/TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html patching file Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm patching file Tools/TestWebKitAPI/cocoa/TestWKWebView.mm patching file Tools/TestWebKitAPI/ios/DataInteractionSimulator.h patching file Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3081168

Wenson Hsieh

Comment 9 2017-02-13 14:48:10 PST

Created attachment 301393 [details] Patch for landing

Wenson Hsieh

Comment 10 2017-02-13 14:48:37 PST

Comment on attachment 301391 [details] Patch for landing Needed rebasing.

WebKit Commit Bot

Comment 11 2017-02-13 15:11:47 PST

Comment on attachment 301393 [details] Patch for landing Clearing flags on attachment: 301393 Committed r212254: <http://trac.webkit.org/changeset/212254>

Note You need to log in before you can comment on or make changes to this bug.