Bug 168158

Summary: WebKitLegacy doesn't re-export various symbols from WebCore required by clients
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit APIAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, andersca, ap, commit-queue, juergen, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168342
https://bugs.webkit.org/show_bug.cgi?id=169341
Attachments:
Description Flags
Proposed patch
mitz: review+
Updated patch none

Description Aakash Jain 2017-02-10 18:54:23 PST 
WebKitLegacy doesn't re-export various symbols from WebCore, which are required by clients. Therefore many clients are forced to link WebCore, while they should be linking against WebKit. WebKit should re-export all such required symbols from WebCore.
Comment 1 Aakash Jain 2017-02-10 18:57:32 PST 
Created attachment 301236 [details]
Proposed patch
Comment 2 Aakash Jain 2017-02-10 19:05:11 PST 
see rdar://problem/26182452 and rdar://problem/24527933
Comment 3 mitz 2017-02-10 20:04:56 PST 
Comment on attachment 301236 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301236&action=review

> Source/WebKit/ios/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=168158

Please add the Radar URL(s) here as well.
Comment 4 Aakash Jain 2017-02-10 20:41:55 PST 
Created attachment 301241 [details]
Updated patch
Comment 5 WebKit Commit Bot 2017-02-10 20:56:07 PST 
Comment on attachment 301241 [details]
Updated patch

Clearing flags on attachment: 301241

Committed r212179: <http://trac.webkit.org/changeset/212179>
Comment 6 WebKit Commit Bot 2017-02-10 20:56:11 PST 
All reviewed patches have been landed.  Closing bug.