Bug 168141

Summary: [Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly
Product: WebKit Reporter: BJ Burg <bburg>
Component: Web InspectorAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix none

Description BJ Burg 2017-02-10 11:59:18 PST 
We are trying to look up the ObjC-stylized property name in the payload, not the raw member name. So we improperly convert objects with fields 'id' and 'description'.
Comment 1 BJ Burg 2017-02-10 12:07:53 PST 
Created attachment 301192 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2017-02-10 12:09:16 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Joseph Pecoraro 2017-02-10 15:23:32 PST 
Comment on attachment 301192 [details]
Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-02-10 15:48:37 PST 
Comment on attachment 301192 [details]
Proposed Fix

Clearing flags on attachment: 301192

Committed r212157: <http://trac.webkit.org/changeset/212157>
Comment 5 WebKit Commit Bot 2017-02-10 15:48:42 PST 
All reviewed patches have been landed.  Closing bug.