RESOLVED FIXED 168141
[Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly 
https://bugs.webkit.org/show_bug.cgi?id=168141
Summary [Cocoa] Web Inspector: payload initializers for ObjC protocol types handles s...
Blaze Burg
Reported 2017-02-10 11:59:18 PST
We are trying to look up the ObjC-stylized property name in the payload, not the raw member name. So we improperly convert objects with fields 'id' and 'description'.
Attachments
Proposed Fix (3.60 KB, patch)
2017-02-10 12:07 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-02-10 12:07:53 PST
Created attachment 301192 [details] Proposed Fix
WebKit Commit Bot
Comment 2 2017-02-10 12:09:16 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Joseph Pecoraro
Comment 3 2017-02-10 15:23:32 PST
Comment on attachment 301192 [details] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2017-02-10 15:48:37 PST
Comment on attachment 301192 [details] Proposed Fix Clearing flags on attachment: 301192 Committed r212157: <http://trac.webkit.org/changeset/212157>
WebKit Commit Bot
Comment 5 2017-02-10 15:48:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.