Bug 168141 - [Cocoa] Web Inspector: payload initializers for ObjC protocol types handles special-cased property names incorrectly
Summary: [Cocoa] Web Inspector: payload initializers for ObjC protocol types handles s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-10 11:59 PST by Brian Burg
Modified: 2017-02-10 15:48 PST (History)
8 users (show)

See Also:


Attachments
Proposed Fix (3.60 KB, patch)
2017-02-10 12:07 PST, Brian Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2017-02-10 11:59:18 PST
We are trying to look up the ObjC-stylized property name in the payload, not the raw member name. So we improperly convert objects with fields 'id' and 'description'.
Comment 1 Brian Burg 2017-02-10 12:07:53 PST
Created attachment 301192 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2017-02-10 12:09:16 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Joseph Pecoraro 2017-02-10 15:23:32 PST
Comment on attachment 301192 [details]
Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2017-02-10 15:48:37 PST
Comment on attachment 301192 [details]
Proposed Fix

Clearing flags on attachment: 301192

Committed r212157: <http://trac.webkit.org/changeset/212157>
Comment 5 WebKit Commit Bot 2017-02-10 15:48:42 PST
All reviewed patches have been landed.  Closing bug.