Bug 168127

Summary:

Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none

Simon Fraser (smfr)

Reported 2017-02-10 10:23:15 PST

Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections

Attachments
Patch (20.17 KB, patch) 2017-02-10 10:25 PST, Simon Fraser (smfr)	thorton: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.51 MB, application/zip) 2017-02-10 11:29 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (985.68 KB, application/zip) 2017-02-10 11:31 PST, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.85 MB, application/zip) 2017-02-10 11:44 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2017-02-10 10:25:39 PST

Created attachment 301169 [details] Patch

WebKit Commit Bot

Comment 2 2017-02-10 10:27:02 PST

Attachment 301169 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:564: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:668: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Radar WebKit Bug Importer

Comment 3 2017-02-10 10:30:00 PST

<rdar://problem/30467120>

Tim Horton

Comment 4 2017-02-10 10:44:40 PST

Comment on attachment 301169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301169&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:668 > +void GraphicsLayer::traverse(GraphicsLayer& layer, std::function<void (GraphicsLayer&)> traversalFunc) Good idea!

Build Bot

Comment 5 2017-02-10 11:29:32 PST

Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3063573 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html

Build Bot

Comment 6 2017-02-10 11:29:35 PST

Created attachment 301183 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-02-10 11:31:32 PST

Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3063517 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html

Build Bot

Comment 8 2017-02-10 11:31:36 PST

Created attachment 301184 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-02-10 11:44:19 PST

Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3063603 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html

Build Bot

Comment 10 2017-02-10 11:44:22 PST

Created attachment 301186 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Simon Fraser (smfr)

Comment 11 2017-02-10 15:04:43 PST

https://trac.webkit.org/r212153

Note You need to log in before you can comment on or make changes to this bug.