| Summary: | Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Simon Fraser (smfr)
2017-02-10 10:23:15 PST
Created attachment 301169 [details]
Patch
Attachment 301169 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:564: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:668: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 2 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 301169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301169&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:668 > +void GraphicsLayer::traverse(GraphicsLayer& layer, std::function<void (GraphicsLayer&)> traversalFunc) Good idea! Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3063573 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html Created attachment 301183 [details]
Archive of layout-test-results from ews103 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3063517 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html Created attachment 301184 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 301169 [details] Patch Attachment 301169 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3063603 New failing tests: compositing/tiling/tiled-mask-inwindow.html compositing/tiling/tiled-reflection-inwindow.html Created attachment 301186 [details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
|