Bug 168127 - Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
Summary: Make sure the "inwindow" flag propagates to TiledBackings for masks and refle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-10 10:23 PST by Simon Fraser (smfr)
Modified: 2017-02-10 15:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (20.17 KB, patch)
2017-02-10 10:25 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1.51 MB, application/zip)
2017-02-10 11:29 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (985.68 KB, application/zip)
2017-02-10 11:31 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.85 MB, application/zip)
2017-02-10 11:44 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-10 10:23:15 PST 
Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
Comment 1 Simon Fraser (smfr) 2017-02-10 10:25:39 PST 
Created attachment 301169 [details]
Patch
Comment 2 WebKit Commit Bot 2017-02-10 10:27:02 PST 
Attachment 301169 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/GraphicsLayer.h:564:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsLayer.cpp:668:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Radar WebKit Bug Importer 2017-02-10 10:30:00 PST 
<rdar://problem/30467120>
Comment 4 Tim Horton 2017-02-10 10:44:40 PST 
Comment on attachment 301169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301169&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:668
> +void GraphicsLayer::traverse(GraphicsLayer& layer, std::function<void (GraphicsLayer&)> traversalFunc)

Good idea!
Comment 5 Build Bot 2017-02-10 11:29:32 PST 
Comment on attachment 301169 [details]
Patch

Attachment 301169 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3063573

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/tiled-reflection-inwindow.html
Comment 6 Build Bot 2017-02-10 11:29:35 PST 
Created attachment 301183 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Build Bot 2017-02-10 11:31:32 PST 
Comment on attachment 301169 [details]
Patch

Attachment 301169 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3063517

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/tiled-reflection-inwindow.html
Comment 8 Build Bot 2017-02-10 11:31:36 PST 
Created attachment 301184 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-02-10 11:44:19 PST 
Comment on attachment 301169 [details]
Patch

Attachment 301169 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3063603

New failing tests:
compositing/tiling/tiled-mask-inwindow.html
compositing/tiling/tiled-reflection-inwindow.html
Comment 10 Build Bot 2017-02-10 11:44:22 PST 
Created attachment 301186 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 11 Simon Fraser (smfr) 2017-02-10 15:04:43 PST 
https://trac.webkit.org/r212153