Summary: | Mail hangs when removing multiple rows from large table. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | HTML Editing | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, rniwa, simon.fraser | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2017-02-09 20:49:00 PST
Created attachment 301127 [details]
Patch
Comment on attachment 301127 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301127&action=review > Source/WebCore/editing/DeleteSelectionCommand.cpp:395 > - removeNode(remove, shouldAssumeContentIsAlwaysEditable); > + removeNode(remove, shouldAssumeContentIsAlwaysEditable, LayoutTiming::Delayed); Instead of adding a new flag like this. We should be able to directly call CompositeEditCommand's removeNode with the code below if (node == m_startBlock...) So I think it's better if we extracted a new helper function e.g. removeNodeUpdatingStates that we call here instead of using a mutual recursion with a different flag. r=me with that change. Comment on attachment 301127 [details] Patch Attachment 301127 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3058047 New failing tests: editing/execCommand/indent-right-after-table.html editing/deleting/5433862-1.html editing/execCommand/5658933-1.html editing/execCommand/5481523.html editing/execCommand/delete-table-with-empty-contents.html editing/deleting/4922367.html editing/execCommand/format-block-table.html editing/execCommand/5144139-1.html editing/deleting/5206311-2.html editing/execCommand/indent-partial-table.html editing/deleting/5206311-1.html editing/execCommand/5483526.html Created attachment 301134 [details]
Archive of layout-test-results from ews112 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 301193 [details]
Patch
Comment on attachment 301193 [details] Patch Clearing flags on attachment: 301193 Committed r212151: <http://trac.webkit.org/changeset/212151> All reviewed patches have been landed. Closing bug. |