Bug 168097 – [Cocoa] Add shouldChangeSelectedRange to WKWebProcessPlugInEditingDelegate

• Component: WebKit API
• Status: RESOLVED FIXED

Expose InjectedBundle::EditorClient::shouldChangeSelectedRange via WKWebProcessPlugInEditingDelegate.

Created attachment 301198 [details]
Add new delegate method and make sure it is called for user-initiated changes on iOS as well

[WebKit Commit Bot]

Attachment 301198 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:610:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 301198 [details]
Add new delegate method and make sure it is called for user-initiated changes on iOS as well

View in context: https://bugs.webkit.org/attachment.cgi?id=301198&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:621
> +                toRange:toRange ? adoptNS([[WKDOMRange alloc] _initWithImpl:toRange]).get() : nil affinity:cocoaAffinity stillSelecting:stillSelecting];

Can we pull the range out into a variable so as not to have this insane syntax?

(In reply to comment #3)
> Comment on attachment 301198 [details]
> Add new delegate method and make sure it is called for user-initiated
> changes on iOS as well
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=301198&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:621
> > +                toRange:toRange ? adoptNS([[WKDOMRange alloc] _initWithImpl:toRange]).get() : nil affinity:cocoaAffinity stillSelecting:stillSelecting];
> 
> Can we pull the range out into a variable so as not to have this insane
> syntax?

OK.

Committed <https://trac.webkit.org/r212149>.