Bug 168080

Summary: Add mediaStreamEnabled property to WKWebViewConfiguration
Product: WebKit Reporter: Andrew Gold <agold>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, agold, commit-queue, eric.carlson, jonlee, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch v2 none

Andrew Gold
Reported 2017-02-09 15:01:32 PST
Add the ability to enable media stream to the Cocoa API.
Attachments
proposed patch (3.36 KB, patch)
2017-02-09 15:50 PST, Andrew Gold 		no flags
DetailsFormatted DiffDiff
proposed patch v2 (6.27 KB, patch)
2017-02-10 15:24 PST, Andrew Gold 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrew Gold
Comment 1 2017-02-09 15:50:36 PST
Created attachment 301094 [details] proposed patch
Tim Horton
Comment 2 2017-02-10 10:43:31 PST
Comment on attachment 301094 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=301094&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:70 > +@property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); Is this the kind of feature that you would want to toggle dynamically? Is it even possible to toggle it dynamically? Otherwise it belongs in WKWebViewConfiguration.
Tim Horton
Comment 3 2017-02-10 10:43:45 PST
Also, gotta set r?
Andrew Gold
Comment 4 2017-02-10 15:23:33 PST
Title updated based off of Tim's feedback.
Andrew Gold
Comment 5 2017-02-10 15:24:54 PST
Created attachment 301201 [details] proposed patch v2
WebKit Commit Bot
Comment 6 2017-02-10 15:56:49 PST
Comment on attachment 301201 [details] proposed patch v2 Clearing flags on attachment: 301201 Committed r212163: <http://trac.webkit.org/changeset/212163>
WebKit Commit Bot
Comment 7 2017-02-10 15:56:53 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.