Bug 168080

Summary: Add mediaStreamEnabled property to WKWebViewConfiguration
Product: WebKit Reporter: Andrew Gold <agold>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, agold, commit-queue, eric.carlson, jonlee, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch v2 none

Description Andrew Gold 2017-02-09 15:01:32 PST
Add the ability to enable media stream to the Cocoa API.
Comment 1 Andrew Gold 2017-02-09 15:50:36 PST
Created attachment 301094 [details]
proposed patch
Comment 2 Tim Horton 2017-02-10 10:43:31 PST
Comment on attachment 301094 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301094&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h:70
> +@property (nonatomic, setter=_setMediaStreamEnabled:) BOOL _mediaStreamEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Is this the kind of feature that you would want to toggle dynamically? Is it even possible to toggle it dynamically? Otherwise it belongs in WKWebViewConfiguration.
Comment 3 Tim Horton 2017-02-10 10:43:45 PST
Also, gotta set r?
Comment 4 Andrew Gold 2017-02-10 15:23:33 PST
Title updated based off of Tim's feedback.
Comment 5 Andrew Gold 2017-02-10 15:24:54 PST
Created attachment 301201 [details]
proposed patch v2
Comment 6 WebKit Commit Bot 2017-02-10 15:56:49 PST
Comment on attachment 301201 [details]
proposed patch v2

Clearing flags on attachment: 301201

Committed r212163: <http://trac.webkit.org/changeset/212163>
Comment 7 WebKit Commit Bot 2017-02-10 15:56:53 PST
All reviewed patches have been landed.  Closing bug.