Bug 168078

Summary:

cleanup WebLocalizableStrings

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

WebKit Misc.

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, achristensen, ap, commit-queue, juergen

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Updated patch	none
Updated patch	none

Aakash Jain

Reported 2017-02-09 14:20:39 PST

mac/Misc/WebLocalizableStrings.mm seems to be unused and mac/Misc/WebLocalizableStrings.h seems to have unused methods. We should clean it up.

Attachments
Proposed patch (10.34 KB, patch) 2017-02-09 14:23 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (10.85 KB, patch) 2017-02-09 14:27 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Updated patch (1.40 KB, patch) 2017-02-10 11:46 PST, Aakash Jain	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2017-02-09 14:23:16 PST

Created attachment 301084 [details] Proposed patch

Aakash Jain

Comment 2 2017-02-09 14:27:30 PST

Created attachment 301086 [details] Updated patch

Alex Christensen

Comment 3 2017-02-09 17:19:36 PST

Comment on attachment 301086 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=301086&action=review > Source/WebKit/mac/Misc/WebLocalizableStrings.h:51 > +__attribute__((visibility("hidden"))) Exporting in WebCore uses something like this (WEBCORE_EXPORT). Exporting in WebKit uses WebKit.exp right now, so this won't change anything.

Aakash Jain

Comment 4 2017-02-10 11:46:17 PST

Created attachment 301187 [details] Updated patch WebLocalizedStringWithValue is actually used in other frameworks, so it can't be deleted. Simplified the patch. We need visibility hidden for WebLocalizableStringsBundle as it's for each framework's own consumption, and never needs to be exported. Few other tools also require the header file to export only what is required.

Alexey Proskuryakov

Comment 5 2017-02-10 12:28:37 PST

> Exporting in WebCore uses something like this (WEBCORE_EXPORT). Exporting in WebKit uses WebKit.exp right now, so this won't change anything. This is an SPI header, and the expectation is that all symbols in API/SPI headers are also available to link against.

WebKit Commit Bot

Comment 6 2017-02-10 13:26:18 PST

Comment on attachment 301187 [details] Updated patch Clearing flags on attachment: 301187 Committed r212143: <http://trac.webkit.org/changeset/212143>

WebKit Commit Bot

Comment 7 2017-02-10 13:26:22 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.