Bug 168058

Summary: Remove usused header WebResourceLoadDelegatePrivate.h
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: WebKit Misc.Assignee: Aakash Jain <aakash_jain>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: aakash_jain, aestes, ap, beidson, juergen, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=168096
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Aakash Jain
Reported 2017-02-09 11:18:24 PST
WebResourceLoadDelegatePrivate.h header is never used. It should be deleted.
Attachments
Proposed patch (5.88 KB, patch)
2017-02-09 11:20 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (10.46 KB, patch)
2017-02-09 11:33 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2017-02-09 11:20:21 PST
Created attachment 301057 [details] Proposed patch
Aakash Jain
Comment 2 2017-02-09 11:33:36 PST
Created attachment 301060 [details] Updated patch
Alexey Proskuryakov
Comment 3 2017-02-09 13:22:46 PST
This seems like it should be fine, but having an entirely unimplemented category so surprising that maybe I'm missing something. Deferring review to others.
mitz
Comment 4 2017-02-09 14:31:09 PST
(In reply to comment #0) > WebResourceLoadDelegatePrivate.h header is never used. It should be deleted. This header declares an informal protocol. We have code to send at least some of the messages in the protocol to the delegate, and there are SPI clients that implement at least some of the delegate methods. Even if all of these things happen to work without the header, it seems like it should be there to serve as documentation and to allow WebKit to compile with stricter options (which forbid @selector with an unknown selector).
Aakash Jain
Comment 5 2017-02-09 14:38:23 PST
In that case, would it be fine to make it a project header instead of private header?
mitz
Comment 6 2017-02-09 14:42:51 PST
(In reply to comment #5) > In that case, would it be fine to make it a project header instead of > private header? This is part of the private client interface. I don’t think it’s right to hide it unless we have a very good reason. Someone working on one of the clients may wonder why their source code includes an implementation of one of those methods, and being able to find the declaration in the SDK is useful in that case.
Alexey Proskuryakov
Comment 7 2017-02-09 15:36:22 PST
Would switching to @protocol make sense?
mitz
Comment 8 2017-02-09 16:15:12 PST
(In reply to comment #7) > Would switching to @protocol make sense? It would improve the API, but it’s a source-breaking change, so it would require some Apple-internal process.
Aakash Jain
Comment 9 2017-02-10 11:25:55 PST
ok. did another change in https://bugs.webkit.org/show_bug.cgi?id=168096 to fix the WebResourceLoadDelegatePrivate.h
Note You need to log in before you can comment on or make changes to this bug.