Bug 168035

Summary: Put names on more UIViews for ease of debugging
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2017-02-08 21:08:21 PST
Put names on more UIViews for ease of debugging
Attachments
Patch (9.87 KB, patch)
2017-02-08 21:09 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-02-08 21:09:03 PST
Created attachment 301012 [details] Patch
Tim Horton
Comment 2 2017-02-08 21:18:46 PST
Comment on attachment 301012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301012&action=review > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:211 > m_liveSwipeViewClippingView = adoptNS([[UIView alloc] initWithFrame:liveSwipeViewFrame]); Think these should both mention swipe. > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:79 > #endif Why some lowercase?
Simon Fraser (smfr)
Comment 3 2017-02-08 21:21:55 PST
(In reply to comment #2) > Comment on attachment 301012 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=301012&action=review > > > Source/WebKit2/UIProcess/ios/ViewGestureControllerIOS.mm:211 > > m_liveSwipeViewClippingView = adoptNS([[UIView alloc] initWithFrame:liveSwipeViewFrame]); > > Think these should both mention swipe. Will fix. > > Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:79 > > #endif > > Why some lowercase? Because that was convention for WebCore things; I chose lowercase for things we make from GraphicsLayers, and InterCaps for UIView things.
Simon Fraser (smfr)
Comment 4 2017-02-08 21:25:09 PST
https://trac.webkit.org/r211929
Note You need to log in before you can comment on or make changes to this bug.