Bug 168028

Summary: Custom protocols should not continue loading after a network process crash
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2017-02-08 16:56:26 PST
Custom protocols should not continue loading after a network process crash
Attachments
Patch (7.70 KB, patch)
2017-02-08 17:03 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (8.04 KB, patch)
2017-02-08 17:37 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-02-08 16:57:07 PST
rdar://problem/27607520
Andy Estes
Comment 2 2017-02-08 17:03:40 PST
Created attachment 300987 [details] Patch
Brady Eidson
Comment 3 2017-02-08 17:05:55 PST
Comment on attachment 300987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300987&action=review > Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92 > + _customProtocolManagerProxy = nullptr; > + [_urlConnection cancel]; Should the cancel be before the nullptr assignment?
Andy Estes
Comment 4 2017-02-08 17:09:25 PST
(In reply to comment #3) > Comment on attachment 300987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300987&action=review > > > Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92 > > + _customProtocolManagerProxy = nullptr; > > + [_urlConnection cancel]; > > Should the cancel be before the nullptr assignment? I don't think the order is important. Thanks for the review!
Andy Estes
Comment 5 2017-02-08 17:37:59 PST
Created attachment 300990 [details] Patch
WebKit Commit Bot
Comment 6 2017-02-08 17:58:54 PST
Comment on attachment 300990 [details] Patch Clearing flags on attachment: 300990 Committed r211915: <http://trac.webkit.org/changeset/211915>
WebKit Commit Bot
Comment 7 2017-02-08 17:58:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.