Bug 168028 - Custom protocols should not continue loading after a network process crash
Summary: Custom protocols should not continue loading after a network process crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-08 16:56 PST by Andy Estes
Modified: 2017-02-08 17:58 PST (History)
5 users (show)

See Also:


Attachments
Patch (7.70 KB, patch)
2017-02-08 17:03 PST, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (8.04 KB, patch)
2017-02-08 17:37 PST, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-02-08 16:56:26 PST
Custom protocols should not continue loading after a network process crash
Comment 1 Andy Estes 2017-02-08 16:57:07 PST
rdar://problem/27607520
Comment 2 Andy Estes 2017-02-08 17:03:40 PST
Created attachment 300987 [details]
Patch
Comment 3 Brady Eidson 2017-02-08 17:05:55 PST
Comment on attachment 300987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300987&action=review

> Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92
> +    _customProtocolManagerProxy = nullptr;
> +    [_urlConnection cancel];

Should the cancel be before the nullptr assignment?
Comment 4 Andy Estes 2017-02-08 17:09:25 PST
(In reply to comment #3)
> Comment on attachment 300987 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300987&action=review
> 
> > Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92
> > +    _customProtocolManagerProxy = nullptr;
> > +    [_urlConnection cancel];
> 
> Should the cancel be before the nullptr assignment?

I don't think the order is important.

Thanks for the review!
Comment 5 Andy Estes 2017-02-08 17:37:59 PST
Created attachment 300990 [details]
Patch
Comment 6 WebKit Commit Bot 2017-02-08 17:58:54 PST
Comment on attachment 300990 [details]
Patch

Clearing flags on attachment: 300990

Committed r211915: <http://trac.webkit.org/changeset/211915>
Comment 7 WebKit Commit Bot 2017-02-08 17:58:57 PST
All reviewed patches have been landed.  Closing bug.