Custom protocols should not continue loading after a network process crash
rdar://problem/27607520
Created attachment 300987 [details] Patch
Comment on attachment 300987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300987&action=review > Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92 > + _customProtocolManagerProxy = nullptr; > + [_urlConnection cancel]; Should the cancel be before the nullptr assignment?
(In reply to comment #3) > Comment on attachment 300987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300987&action=review > > > Source/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:92 > > + _customProtocolManagerProxy = nullptr; > > + [_urlConnection cancel]; > > Should the cancel be before the nullptr assignment? I don't think the order is important. Thanks for the review!
Created attachment 300990 [details] Patch
Comment on attachment 300990 [details] Patch Clearing flags on attachment: 300990 Committed r211915: <http://trac.webkit.org/changeset/211915>
All reviewed patches have been landed. Closing bug.