Bug 168019

Summary:

[Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Fix	none

Description BJ Burg 2017-02-08 14:04:30 PST

This is useful for parsing out the 'platform' value programmatically without hardcoding specific protocol level strings.

Comment 1 BJ Burg 2017-02-08 14:04:55 PST

<rdar://problem/28718990>

Comment 2 BJ Burg 2017-02-08 15:52:46 PST

Created attachment 300979 [details]
Proposed Fix

Comment 3 WebKit Commit Bot 2017-02-08 15:54:48 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 4 WebKit Commit Bot 2017-02-08 15:54:58 PST

Attachment 300979 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:112:  [ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_conversion_for_platforms] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:139:  [ObjCHeaderGenerator._generate_enum_for_platforms] Instance of 'ObjCHeaderGenerator' has no 'objc_prefix' member  [pylint/E1101] [5]
Total errors found: 2 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Joseph Pecoraro 2017-02-09 22:36:03 PST

Comment on attachment 300979 [details]
Proposed Fix

r=me

Comment 6 WebKit Commit Bot 2017-02-10 09:31:11 PST

Comment on attachment 300979 [details]
Proposed Fix

Clearing flags on attachment: 300979

Committed r212116: <http://trac.webkit.org/changeset/212116>

Comment 7 WebKit Commit Bot 2017-02-10 09:31:15 PST

All reviewed patches have been landed.  Closing bug.