WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
168019
[Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by the protocol code generator
https://bugs.webkit.org/show_bug.cgi?id=168019
Summary
[Cocoa] Web Inspector: generate an NS_ENUM containing platforms supported by ...
Blaze Burg
Reported
2017-02-08 14:04:30 PST
This is useful for parsing out the 'platform' value programmatically without hardcoding specific protocol level strings.
Attachments
Proposed Fix
(47.87 KB, patch)
2017-02-08 15:52 PST
,
Blaze Burg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Blaze Burg
Comment 1
2017-02-08 14:04:55 PST
<
rdar://problem/28718990
>
Blaze Burg
Comment 2
2017-02-08 15:52:46 PST
Created
attachment 300979
[details]
Proposed Fix
WebKit Commit Bot
Comment 3
2017-02-08 15:54:48 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4
2017-02-08 15:54:58 PST
Attachment 300979
[details]
did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:112: [ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_conversion_for_platforms] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:139: [ObjCHeaderGenerator._generate_enum_for_platforms] Instance of 'ObjCHeaderGenerator' has no 'objc_prefix' member [pylint/E1101] [5] Total errors found: 2 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 5
2017-02-09 22:36:03 PST
Comment on
attachment 300979
[details]
Proposed Fix r=me
WebKit Commit Bot
Comment 6
2017-02-10 09:31:11 PST
Comment on
attachment 300979
[details]
Proposed Fix Clearing flags on attachment: 300979 Committed
r212116
: <
http://trac.webkit.org/changeset/212116
>
WebKit Commit Bot
Comment 7
2017-02-10 09:31:15 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug