Summary: | Promote WKWebView.allowsRemoteInspection from SPI to API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Blaze Burg <bburg> | ||||||
Component: | WebKit API | Assignee: | Blaze Burg <bburg> | ||||||
Status: | NEW --- | ||||||||
Severity: | Normal | CC: | andersca, bburg, ggaren, joepeck, mjs, webkit-bug-importer, webkitbugzilla | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Blaze Burg
2017-02-08 11:55:12 PST
Created attachment 301854 [details]
Patch
Did we submit this to API review? (In reply to comment #2) > Did we submit this to API review? No. Should we? I was under the impression to check it in first. Yeah, I think we should submit for review and then check in. Comment on attachment 301854 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301854&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.h:240 > +@property This doesn't match the format of other comments. The @property can be dropped and the @abstract on the same line as the /*! Created attachment 301983 [details]
Patch v2
Comment on attachment 301983 [details]
Patch v2
This seems like a good idea, and I'm surprised this is still SPI, but r- because the patch no longer applies.
|