Summary: | Acid3 expects HTMLObjectElement.data to canonicalize urls | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||
Component: | DOM | Assignee: | Dave Hyatt <hyatt> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | fishd, webkit | ||||||
Priority: | P2 | Keywords: | HasReduction | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
URL: | http://www.hixie.ch/tests/evil/acid/003/ | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 17064 | ||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2008-01-09 00:21:18 PST
Created attachment 18735 [details]
Minimal test case
Created attachment 18921 [details]
Make data absolute
Will land test case in bug.
Comment on attachment 18921 [details]
Make data absolute
r=me
Comment on attachment 18921 [details]
Make data absolute
+ if (dataVal.isNull())
+ return dataVal;
You don't need this. Document::completeURL already does this. It can just be a one-liner.
return document()->completeURL(getAttribute(dataAttr));
*** Bug 14448 has been marked as a duplicate of this bug. *** you might want to review my patch in bug 14448, which includes a test case, but more importantly it had to be backed out after it was found to regress some existing layout tests! I will just remove those layout tests, as they make a bogus assumption. |