Bug 167985

Summary: [GTK] Test fast/forms/select-empty-option-height.html fails
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, tonikitoo
Priority: P2 Keywords: Gtk, LayoutTestFailure
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-02-08 06:43:04 PST
This seems to be a problem with the differences in scroll step or the size of the items in the list. The thing is that 10 attempts with an scroll amount of 10 is not enoug in the GTk+ port to scroll the list to the desired point. Either increasing the scroll amount or the maximum attempts would fix the test. Increasing the scroll amount would break the test in other ports so better use a higher number of maximum attempts.
Attachments
Patch (1.65 KB, patch)
2017-02-08 06:45 PST, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-02-08 06:45:44 PST
Created attachment 300893 [details] Patch
Michael Catanzaro
Comment 2 2017-02-08 07:50:21 PST
Comment on attachment 300893 [details] Patch We expect our list items to use theme size and not match other ports, I presume?
Carlos Garcia Campos
Comment 3 2017-02-08 08:27:24 PST
Committed r211872: <http://trac.webkit.org/changeset/211872>
Note You need to log in before you can comment on or make changes to this bug.