Bug 167980

Summary: [GTK] Reduce TiledBackingStore tile coverage when on memory pressure state
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WebKitGTKAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cmarcelo, commit-queue, kondapallykalyan, luiz, noam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Miguel Gomez
Reported 2017-02-08 02:32:42 PST
Currently we use a hardcoded coverAreaMultiplier value of 2 in the TiledBackingStore, which means that the area we fill with tiles has up to 2 times the size of the visible area. While this is nice to make scrolling smoother, we are using more memory than needed to render the visible contents of layers (1 extra MB per tile). When we are in memory pressure situation, we can reduce that value to use less tiles and improve the memory consumption.
Attachments
Patch (4.03 KB, patch)
2017-02-08 02:39 PST, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2017-02-08 03:09 PST, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2017-02-08 02:39:10 PST
Created attachment 300885 [details] Patch
Carlos Garcia Campos
Comment 2 2017-02-08 02:44:20 PST
Comment on attachment 300885 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300885&action=review > Source/WebCore/platform/graphics/texmap/coordinated/TiledBackingStore.cpp:148 > +void TiledBackingStore::createTiles(const IntRect& visibleRect, const IntRect& scaledContentsRect, const float coverAreaMultiplier) I don't think that const is needed for a float parameter passed by value, no?
Miguel Gomez
Comment 3 2017-02-08 03:09:04 PST
Created attachment 300887 [details] Patch
WebKit Commit Bot
Comment 4 2017-02-08 04:20:37 PST
Comment on attachment 300887 [details] Patch Clearing flags on attachment: 300887 Committed r211867: <http://trac.webkit.org/changeset/211867>
WebKit Commit Bot
Comment 5 2017-02-08 04:20:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.