Bug 167933

Summary:

[Modern Media Controls] Implement reduced and tight padding modes

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews123 for ios-simulator-wk2	none
Patch for landing	none

Antoine Quint

Reported 2017-02-07 07:07:58 PST

The modern media controls, on top of allowing for a compact/legacy mode, also have "reduced" and "tight" padding modes: - in the scrubber's absence, inline video controls at or below 300pt width use a 12pt left margin for the left buttons container, and a 12pt right margin for the right buttons container, and 16pth button margin inside both containers - when dropping at or below 120pt width, inline video controls use an 8pt left margin for the left buttons container, and an 8pt right margin for the right buttons container, and 12pt button margin inside both containers - in the case of audio controls, at 400pt or less, inline controls switch to 12pt margins and button margins for both buttons containers

Attachments
Patch (69.78 KB, patch) 2017-02-08 12:53 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (883.49 KB, application/zip) 2017-02-08 14:09 PST, Build Bot	no flags	Details
Patch for landing (69.70 KB, patch) 2017-02-08 14:20 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-02-07 07:08:27 PST

<rdar://problem/30396994>

Antoine Quint

Comment 2 2017-02-07 07:31:12 PST

Actually, the 120pt or below case is already covered by the compact controls.

Antoine Quint

Comment 3 2017-02-08 12:53:14 PST

Created attachment 300940 [details] Patch

Build Bot

Comment 4 2017-02-08 14:09:46 PST

Comment on attachment 300940 [details] Patch Attachment 300940 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3027138 New failing tests: media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html

Build Bot

Comment 5 2017-02-08 14:09:48 PST

Created attachment 300959 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antoine Quint

Comment 6 2017-02-08 14:20:40 PST

Created attachment 300965 [details] Patch for landing

WebKit Commit Bot

Comment 7 2017-02-08 14:59:11 PST

Comment on attachment 300965 [details] Patch for landing Clearing flags on attachment: 300965 Committed r211904: <http://trac.webkit.org/changeset/211904>

WebKit Commit Bot

Comment 8 2017-02-08 14:59:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.