Bug 167931

Summary: [GTK][Efl] Do not require LibXslt if XSLT is disabled
Product: WebKit Reporter: Olivier Blin <olivier.blin>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, bugs-noreply, commit-queue, gyuyoung.kim, mcatanzaro, zan
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Olivier Blin
Reported 2017-02-07 06:04:22 PST
Build with --no-xslt fails when the libxslt dev files are not installed, while they are not needed.
Attachments
Patch (2.42 KB, patch)
2017-02-07 06:44 PST, Olivier Blin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Olivier Blin
Comment 1 2017-02-07 06:44:16 PST
Created attachment 300807 [details] Patch
Olivier Blin
Comment 2 2017-02-07 06:45:40 PST
As a side note, this has been noticed on WebKitForWayland first, it would be nice to factorize options that are common to non-Apple ports (GTK, Efl, WPE, Qt).
Michael Catanzaro
Comment 3 2017-02-07 08:36:51 PST
Comment on attachment 300807 [details] Patch I don't think we should support building with ENABLE_XSLT=OFF. Why do you want to do this?
Konstantin Tokarev
Comment 4 2017-02-07 08:42:38 PST
FWIW, I do this to avoid extra dependency and reduce WebKit size a bit for embedded system, XSLT is not a very popular Web feature
Olivier Blin
Comment 5 2017-02-07 08:45:06 PST
Because I don't need libxslt and the XSL stylesheets feature in my embedded systems (set-top boxes).
Michael Catanzaro
Comment 6 2017-02-07 08:56:22 PST
Comment on attachment 300807 [details] Patch *grumble not supported grumble*
Adrian Perez
Comment 7 2017-02-07 09:02:47 PST
It makes sense to be able to disable seldom used features (like XSLT) at build time, when targeting embedded hardware with limited resources. This is something that it's interesting to support. XSLT should be enabled and built by default, though. As long as the proposed patch keeps XSLT enabled unless explicitly disabled, it looks good to me.
WebKit Commit Bot
Comment 8 2017-02-07 09:22:28 PST
Comment on attachment 300807 [details] Patch Clearing flags on attachment: 300807 Committed r211813: <http://trac.webkit.org/changeset/211813>
WebKit Commit Bot
Comment 9 2017-02-07 09:22:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.