Bug 167906 – svn-create-patch duplicating deletes

• Component: Tools / Tests
• Status: RESOLVED DUPLICATE

[Jonathan Bedard]

svn-create-patch will duplicate deletes, https://bugs.webkit.org/attachment.cgi?id=300680 is a good example of this.  Among other files, PerformanceTests/ES6SampleBench/Basic/util.js is deleted 3 times.

[Jonathan Bedard]

I was able to reproduce this.

This is a bug in svn-create-patch.  If you delete a file and then move the directory the file that was deleted is in, the resulting patch will have duplicated the delete.  The commands to reproduce this are:

rm SomeDir/file.txt
svn rm SomeDir/file.txt
svn mv SomeDir SomeNewDir

I would guess that this was caused by https://bugs.webkit.org/show_bug.cgi?id=167169.

[Alexey Proskuryakov]

Is this a duplicate of bug 167903?

[Jonathan Bedard]

*** Bug 167903 has been marked as a duplicate of this bug. ***

[Jonathan Bedard]

(In reply to comment #2)
> Is this a duplicate of bug 167903?

Yes, it is the same issue.  Marked the other as a duplicate since this one has more than just a report.

[Alexey Proskuryakov]

*** This bug has been marked as a duplicate of bug 167903 ***

[Alexey Proskuryakov]

Jonathan and I look into this briefly, and this may end up being a separate bug - there are no deletes in bug 167903.

[Jonathan Bedard]

This is not a duplicate of bug 167903, they are different issues.

[David Kilzer (:ddkilzer)]

This is a duplicate of:

Bug 14590: svn-create-patch fails when svn mv is used on directory trees

The patch I have to fix that (not v1) also fixes this issue.

*** This bug has been marked as a duplicate of bug 14590 ***