Bug 167896

Summary: [EME] Alias CDMInstance enums to the specification-defined enums
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2017-02-06 11:40:00 PST
[EME] Utility functions for conversions between CDMInstance and W3C EME enums
Attachments
Patch (10.70 KB, patch)
2017-02-06 11:44 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2017-02-07 06:53 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-02-06 11:44:16 PST
Created attachment 300743 [details] Patch
Sam Weinig
Comment 2 2017-02-06 11:59:15 PST
Comment on attachment 300743 [details] Patch Is there a reason to have both types here? Can we just define one to be the other using a using declaration?
Zan Dobersek
Comment 3 2017-02-07 04:40:08 PST
(In reply to comment #2) > Comment on attachment 300743 [details] > Patch > > Is there a reason to have both types here? Can we just define one to be the > other using a using declaration? That would be the simplest approach. Given that MediaKeySystemConfiguration is already used in CDMInstance, the CDMInstance types could alias to the spec-defined ones. If ever the CDMInstance interface gets pushed into the platform layer, or is used from there, then this would require changing.
Zan Dobersek
Comment 4 2017-02-07 06:53:46 PST
Created attachment 300808 [details] Patch
Sam Weinig
Comment 5 2017-02-07 08:47:38 PST
Comment on attachment 300808 [details] Patch Nice.
Zan Dobersek
Comment 6 2017-02-08 01:36:16 PST
Comment on attachment 300808 [details] Patch Clearing flags on attachment: 300808 Committed r211855: <http://trac.webkit.org/changeset/211855>
Zan Dobersek
Comment 7 2017-02-08 01:36:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.