Bug 167875

Summary:

[Modern Media Controls] Bring fullscreen controls up to spec

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari Technology Preview

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Patch for landing	none

Description Antoine Quint 2017-02-06 05:31:08 PST

We're missing the volume down and volume up buttons in fullscreen on macOS and the PiP button is too large.

Comment 1 Antoine Quint 2017-02-06 05:31:22 PST

<rdar://problem/29611222>

Comment 2 Antoine Quint 2017-02-06 05:41:15 PST

Created attachment 300714 [details]
Patch

Comment 3 Build Bot 2017-02-06 06:42:14 PST

Comment on attachment 300714 [details]
Patch

Attachment 300714 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3013540

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html

Comment 4 Build Bot 2017-02-06 06:42:16 PST

Created attachment 300717 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 5 Antoine Quint 2017-02-06 07:40:26 PST

Created attachment 300721 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2017-02-06 08:18:24 PST

Comment on attachment 300721 [details]
Patch for landing

Clearing flags on attachment: 300721

Committed r211723: <http://trac.webkit.org/changeset/211723>

Comment 7 WebKit Commit Bot 2017-02-06 08:18:27 PST

All reviewed patches have been landed.  Closing bug.