Bug 167863

Summary: Change ES6SampleBench into ARES-6
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dbates, jbedard, jond, lforschler, mjs, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=167906
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2017-02-05 18:26:58 PST
This imports JonDavis's design.
Attachments
the patch (1.82 MB, patch)
2017-02-05 18:28 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-02-05 18:28:45 PST
Created attachment 300680 [details] the patch
Filip Pizlo
Comment 2 2017-02-05 18:55:27 PST
(In reply to comment #1) > Created attachment 300680 [details] > the patch The patch totally does apply to trunk of repository. It's just that it's moving lots of stuff, so probably EWS is having a bad time.
Saam Barati
Comment 3 2017-02-05 20:04:21 PST
Comment on attachment 300680 [details] the patch rs=me
Filip Pizlo
Comment 4 2017-02-05 20:58:13 PST
Landed in https://trac.webkit.org/changeset/211697
Csaba Osztrogonác
Comment 5 2017-02-06 00:38:02 PST
(In reply to comment #4) > Landed in https://trac.webkit.org/changeset/211697 It completely broke run-javascriptcore-tests, ES6SampleBench should have been renamed to ARES-6 in run-javascriptcore-tests too. Fix landed in https://trac.webkit.org/changeset/211717
Csaba Osztrogonác
Comment 6 2017-02-06 00:40:48 PST
> Its now called ARES-6. Just out of curiosity, why? What does this new name mean?
Saam Barati
Comment 7 2017-02-06 11:21:04 PST
This also broke running cli.js with `jsc` shell. I'll work on a fix now.
Filip Pizlo
Comment 8 2017-02-06 13:42:07 PST
(In reply to comment #5) > (In reply to comment #4) > > Landed in https://trac.webkit.org/changeset/211697 > > It completely broke run-javascriptcore-tests, ES6SampleBench should > have been renamed to ARES-6 in run-javascriptcore-tests too. > > Fix landed in https://trac.webkit.org/changeset/211717 Thank you.
Filip Pizlo
Comment 9 2017-02-06 13:42:58 PST
(In reply to comment #6) > > Its now called ARES-6. > > Just out of curiosity, why? What does this new name mean? ES6SampleBench was a weird name. ARES-6 is a fun name. It's purely subjective.
Jonathan Bedard
Comment 10 2017-02-06 14:52:09 PST
Just a note: the failure of svn-apply was because the patch attempts to remove some files multiple time. https://bugs.webkit.org/show_bug.cgi?id=167906 tracks this bug.
Note You need to log in before you can comment on or make changes to this bug.