Bug 167856
| Summary: | [JSC] Add fast BytecodeGraph construction mode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | saam |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 167725 | ||
| Bug Blocks: | |||
Yusuke Suzuki
...
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Saam Barati
This would be cool. What's your plan here to make it faster?
Yusuke Suzuki
(In reply to comment #1)
> This would be cool. What's your plan here to make it faster?
Do not collect BytecodeBasicBlock::m_offsets. Sometimes we do not need this information.
I think this reduces memory allocation if the basic block is super large. Like, kraken's data initialization.
Saam Barati
(In reply to comment #2)
> (In reply to comment #1)
> > This would be cool. What's your plan here to make it faster?
>
> Do not collect BytecodeBasicBlock::m_offsets. Sometimes we do not need this
> information.
> I think this reduces memory allocation if the basic block is super large.
> Like, kraken's data initialization.
Nice! I measured that it took something like 3-5ms to run the algorithm on the huge program code block from ai-astart. So any improvement for this would be awesome.