Bug 167850

Summary: Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cgarcia, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Patch
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan none

Simon Fraser (smfr)
Reported 2017-02-04 21:59:29 PST
Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
Attachments
Patch (35.28 KB, patch)
2017-02-04 22:06 PST, Simon Fraser (smfr) 		thorton: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (929.07 KB, application/zip)
2017-02-04 23:10 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews112 for mac-elcapitan (2.96 MB, application/zip)
2017-02-04 23:51 PST, Build Bot 		no flags
Details
Patch (35.36 KB, patch)
2017-02-05 09:41 PST, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (758.79 KB, application/zip)
2017-02-05 10:55 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-02-04 22:06:44 PST
Created attachment 300659 [details] Patch
Tim Horton
Comment 2 2017-02-04 22:32:03 PST
Comment on attachment 300659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300659&action=review > LayoutTests/pageoverlay/overlay-remove-reinsert-view.html:14 > + function getWaitForPresentationUpdateUIScript() I do wish a bit that these things weren't so wordy.
Build Bot
Comment 3 2017-02-04 23:10:32 PST
Comment on attachment 300659 [details] Patch Attachment 300659 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3007010 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
Build Bot
Comment 4 2017-02-04 23:10:36 PST
Created attachment 300661 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 5 2017-02-04 23:51:04 PST
Comment on attachment 300659 [details] Patch Attachment 300659 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3007011 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
Build Bot
Comment 6 2017-02-04 23:51:07 PST
Created attachment 300662 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 7 2017-02-05 09:41:46 PST
Created attachment 300668 [details] Patch
Build Bot
Comment 8 2017-02-05 10:55:23 PST
Comment on attachment 300668 [details] Patch Attachment 300668 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3009399 New failing tests: pageoverlay/overlay-remove-reinsert-view.html
Build Bot
Comment 9 2017-02-05 10:55:26 PST
Created attachment 300669 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 10 2017-02-05 11:20:58 PST
https://trac.webkit.org/r211683
Carlos Garcia Campos
Comment 11 2017-02-05 22:54:08 PST
*** Bug 167790 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 12 2017-02-10 10:35:57 PST
<rdar://problem/30467272>
Note You need to log in before you can comment on or make changes to this bug.