Bug 167845

Summary: Static Analyzer: Value stored to 'recordedMachineThreads' during its initialization is never read
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 104114    
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-02-04 16:41:39 PST
Seeing the following Static Analyzer Warnings: > AnalyzeShallow heap/MachineStackMarker.cpp > Source/JavaScriptCore/heap/MachineStackMarker.cpp:151:14: warning: Value stored to 'recordedMachineThreads' during its initialization is never read > auto recordedMachineThreads = m_set.take(machineThreads); > ^~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~ > Source/JavaScriptCore/heap/MachineStackMarker.cpp:179:5: warning: Returning null reference > return *manager; > ^~~~~~~~~~~~~~~ > 2 warnings generated. The first seems valid given some context: auto recordedMachineThreads = m_set.take(machineThreads); RELEASE_ASSERT(recordedMachineThreads = machineThreads); Seems the assert should be an `==` instead of an `=`.
Attachments
[PATCH] Proposed Fix (1.61 KB, patch)
2017-02-04 16:43 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-02-04 16:43:43 PST
Created attachment 300647 [details] [PATCH] Proposed Fix
Saam Barati
Comment 2 2017-02-04 21:02:23 PST
Comment on attachment 300647 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 3 2017-02-04 23:03:59 PST
Comment on attachment 300647 [details] [PATCH] Proposed Fix Clearing flags on attachment: 300647 Committed r211678: <http://trac.webkit.org/changeset/211678>
WebKit Commit Bot
Comment 4 2017-02-04 23:04:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-03-10 11:26:02 PST
<rdar://problem/30977452>
Note You need to log in before you can comment on or make changes to this bug.