Bug 167804

Summary:

WKActionSheet should dismiss with animation when done with the sheet

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, enrica, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Wenson Hsieh

Reported 2017-02-03 11:18:57 PST

<rdar://problem/30334861>

Attachments
Patch (4.14 KB, patch) 2017-02-03 11:24 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-02-03 11:24:31 PST

Created attachment 300552 [details] Patch

Tim Horton

Comment 2 2017-02-03 11:28:23 PST

Comment on attachment 300552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300552&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585 > - [_dataInteractionGestureRecognizer setDelay:0.25]; > + [_dataInteractionGestureRecognizer setDelay:0.5]; ?

Wenson Hsieh

Comment 3 2017-02-03 11:42:55 PST

(In reply to comment #2) Thanks! > Comment on attachment 300552 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300552&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585 > > - [_dataInteractionGestureRecognizer setDelay:0.25]; > > + [_dataInteractionGestureRecognizer setDelay:0.5]; > > ? This is still arbitrary, and will be changed to a final value in the near future! Without this, long press to bring up the action sheet seemed unnaturally fast.

WebKit Commit Bot

Comment 4 2017-02-03 12:09:17 PST

Comment on attachment 300552 [details] Patch Clearing flags on attachment: 300552 Committed r211643: <http://trac.webkit.org/changeset/211643>

WebKit Commit Bot

Comment 5 2017-02-03 12:09:20 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.