Bug 167804 - WKActionSheet should dismiss with animation when done with the sheet
Summary: WKActionSheet should dismiss with animation when done with the sheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-03 11:18 PST by Wenson Hsieh
Modified: 2017-02-03 12:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.14 KB, patch)
2017-02-03 11:24 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-02-03 11:18:57 PST 
<rdar://problem/30334861>
Comment 1 Wenson Hsieh 2017-02-03 11:24:31 PST 
Created attachment 300552 [details]
Patch
Comment 2 Tim Horton 2017-02-03 11:28:23 PST 
Comment on attachment 300552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300552&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585
> -    [_dataInteractionGestureRecognizer setDelay:0.25];
> +    [_dataInteractionGestureRecognizer setDelay:0.5];

?
Comment 3 Wenson Hsieh 2017-02-03 11:42:55 PST 
(In reply to comment #2)

Thanks!

> Comment on attachment 300552 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300552&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:585
> > -    [_dataInteractionGestureRecognizer setDelay:0.25];
> > +    [_dataInteractionGestureRecognizer setDelay:0.5];
> 
> ?

This is still arbitrary, and will be changed to a final value in the near future! Without this, long press to bring up the action sheet seemed unnaturally fast.
Comment 4 WebKit Commit Bot 2017-02-03 12:09:17 PST 
Comment on attachment 300552 [details]
Patch

Clearing flags on attachment: 300552

Committed r211643: <http://trac.webkit.org/changeset/211643>
Comment 5 WebKit Commit Bot 2017-02-03 12:09:20 PST 
All reviewed patches have been landed.  Closing bug.