Bug 167762

Summary:

Remove check for SkipSafariExecutableEntitlementChecks

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, ddkilzer, lforschler, mitz

Priority:

Keywords:

InRadar

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
follow-up fix	none
follow-up fix	none

Alexey Proskuryakov

Reported 2017-02-02 15:00:22 PST

rdar://problem/22480673

Attachments
proposed patch (1.72 KB, patch) 2017-02-02 15:01 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
follow-up fix (2.80 KB, patch) 2017-02-03 13:28 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
follow-up fix (2.68 KB, patch) 2017-02-03 14:56 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2017-02-02 15:01:54 PST

Created attachment 300456 [details] proposed patch

WebKit Commit Bot

Comment 2 2017-02-02 16:10:35 PST

Comment on attachment 300456 [details] proposed patch Clearing flags on attachment: 300456 Committed r211606: <http://trac.webkit.org/changeset/211606>

WebKit Commit Bot

Comment 3 2017-02-02 16:10:38 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 4 2017-02-03 13:25:16 PST

Re-opening for follow-up fix.

Alexey Proskuryakov

Comment 5 2017-02-03 13:28:28 PST

Created attachment 300560 [details] follow-up fix

mitz

Comment 6 2017-02-03 14:25:17 PST

Comment on attachment 300560 [details] follow-up fix With this change, the value of WEBKIT_SAFARI appears to be ignored.

Alexey Proskuryakov

Comment 7 2017-02-03 14:56:04 PST

Created attachment 300566 [details] follow-up fix Which is probably a good thing as nothing uses WEBKIT_SAFARI, but restoring the behavior as changing it is not the purpose of this patch.

WebKit Commit Bot

Comment 8 2017-02-03 16:07:18 PST

Comment on attachment 300566 [details] follow-up fix Clearing flags on attachment: 300566 Committed r211657: <http://trac.webkit.org/changeset/211657>

WebKit Commit Bot

Comment 9 2017-02-03 16:07:23 PST

All reviewed patches have been landed. Closing bug.

mitz

Comment 10 2017-03-11 20:23:35 PST

(In reply to comment #8) > Comment on attachment 300566 [details] > follow-up fix > > Clearing flags on attachment: 300566 > > Committed r211657: <http://trac.webkit.org/changeset/211657> Oops, this broke bisect-builds: $ bisect-builds Undefined subroutine &main::safariPathFromSafariBundle called at Tools/Scripts/bisect-builds line 132.

Alexey Proskuryakov

Comment 11 2017-03-11 22:02:58 PST

Sorry about that! Do you know about how this script is used? Specifically, I wonder if the --safari-path argument can be simply removed. There is only one Safari, after all.

mitz

Comment 12 2017-03-11 22:05:25 PST

(In reply to comment #11) > Sorry about that! > > Do you know about how this script is used? Specifically, I wonder if the > --safari-path argument can be simply removed. There is only one Safari, > after all. --safari-path does appear to be superseded by --application, so unless some other script relies on it, it can be removed.

Alexey Proskuryakov

Comment 13 2017-03-11 22:22:07 PST

Filed bug 169522. $ grep -r safari-path Tools/Scripts Tools/Scripts/bisect-builds: "safari-path=s" => \$safariPath, Tools/Scripts/bisect-builds: [--safari-path path] path to Safari application bundle (default: /Applications/Safari.app)

Note You need to log in before you can comment on or make changes to this bug.