Bug 167758

Summary: Build libwebrtc and dependencies with Xcode
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jonlee, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2017-02-02 14:40:10 PST
Build libwebrtc and dependencies with Xcode
Attachments
Patch (2.22 MB, patch)
2017-02-02 14:41 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.21 MB, patch)
2017-02-02 15:00 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-02-02 14:41:10 PST
Created attachment 300452 [details] Patch
WebKit Commit Bot
Comment 2 2017-02-02 14:43:01 PST
Attachment 300452 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dean Jackson
Comment 3 2017-02-02 14:44:39 PST
Comment on attachment 300452 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300452&action=review > Source/ThirdParty/libwebrtc/ChangeLog:14 > + * Source/webrtc/modules/audio_coding/audio_network_adaptor/mock/untitled folder: Added. Remove this!! > Source/WebCore/Configurations/WebCoreTestSupport.xcconfig:52 > +OTHER_LDFLAGS[sdk=macos*] = $(ASAN_OTHER_LDFLAGS) -framework AppKit -lwebrtc -lboringssl; What is boringssl?
Alex Christensen
Comment 4 2017-02-02 15:00:17 PST
Created attachment 300455 [details] Patch
Alex Christensen
Comment 5 2017-02-02 15:32:44 PST
http://trac.webkit.org/r211602
mitz
Comment 6 2017-02-02 15:48:29 PST
Can you explain why you changed the debug configuration to not build with DEBUG=1?
mitz
Comment 7 2017-02-02 15:58:17 PST
Also, the overriding of the C flags from ASAN seems strange.
Alex Christensen
Comment 8 2017-02-02 16:32:56 PST
I started by copying the ANGLE build files. This builds and links successfully. It is entirely likely I overlooked a debug flag
Radar WebKit Bug Importer
Comment 9 2017-02-02 19:33:46 PST
<rdar://problem/30342855>
Jon Lee
Comment 10 2017-02-02 20:06:12 PST
*** Bug 167539 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.