Bug 167754

Summary: Don't attempt wide gamut on older OSes
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, dino, megan_gardner, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Megan Gardner 2017-02-02 13:53:36 PST 
Don't attempt wide gammut on older OSes
Comment 1 Megan Gardner 2017-02-02 14:16:21 PST 
Created attachment 300446 [details]
Patch
Comment 2 Megan Gardner 2017-02-02 14:18:13 PST 
Not sure if we needed the iOS check, but thought I should be more not less thorough.
Comment 3 Tim Horton 2017-02-02 14:44:52 PST 
Comment on attachment 300446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300446&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:65
> +#if (__MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)

No need for the parens.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2500
> +#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 100000)

This matches the extendedSRGBColorSpaceRef() thing, right? Also, no parens.
Comment 4 Megan Gardner 2017-02-02 15:13:44 PST 
Yep, matches. I'll take out parens and commit.
Comment 5 Megan Gardner 2017-02-02 15:26:52 PST 
https://trac.webkit.org/changeset/211601