Bug 167739

Summary:

[Mac] Add classes to manage audio samples

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, jer.noble, thiago.lacerda

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

167767

Bug Blocks:

Attachments:

Description	Flags
Proposed patch	none
Updated patch	jer.noble: review+
Patch for landing.	none
Patch for landing.	none
Updated patch.	none

Eric Carlson

Reported 2017-02-02 09:52:16 PST

Add classes to manage audio samples

Attachments
Proposed patch (46.15 KB, patch) 2017-02-02 11:21 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Updated patch (46.14 KB, patch) 2017-02-02 11:39 PST, Eric Carlson	jer.noble: review+	Details Formatted Diff Diff
Patch for landing. (46.32 KB, patch) 2017-02-02 12:02 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Patch for landing. (46.35 KB, patch) 2017-02-02 13:28 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Updated patch. (46.36 KB, patch) 2017-02-03 08:34 PST, Eric Carlson	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2017-02-02 11:21:24 PST

Created attachment 300423 [details] Proposed patch

WebKit Commit Bot

Comment 2 2017-02-02 11:23:08 PST

Attachment 300423 [details] did not pass style-queue: ERROR: Source/WebCore/platform/audio/mac/AudioSampleBufferList.h:50: The parameter name "format" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 3 2017-02-02 11:39:12 PST

Created attachment 300425 [details] Updated patch

Jer Noble

Comment 4 2017-02-02 11:44:57 PST

Comment on attachment 300425 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=300425&action=review > Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:135 > + kern_return_t kr = mach_timebase_info(&timebaseInfo); > + frequency = 1e-9 * static_cast<double>(timebaseInfo.numer) / static_cast<double>(timebaseInfo.denom); This could use an explanatory comment. > Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:162 > + m_inputSampleOffset = toMediaTime(CMTimeConvertScale(toCMTime(m_inputSampleOffset), sampleTime.timeScale(), kCMTimeRoundingMethod_Default)); Please add a fixme comment about improving MediaTime to add this kind of rounding parameter functionality. > Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:183 > + Space.

Eric Carlson

Comment 5 2017-02-02 12:02:13 PST

Created attachment 300429 [details] Patch for landing.

WebKit Commit Bot

Comment 6 2017-02-02 12:04:26 PST

Attachment 300429 [details] did not pass style-queue: ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:162: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 7 2017-02-02 13:28:16 PST

Created attachment 300443 [details] Patch for landing.

WebKit Commit Bot

Comment 8 2017-02-02 15:03:21 PST

Comment on attachment 300443 [details] Patch for landing. Clearing flags on attachment: 300443 Committed r211596: <http://trac.webkit.org/changeset/211596>

WebKit Commit Bot

Comment 9 2017-02-02 15:03:25 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 10 2017-02-02 16:35:41 PST

Re-opened since this is blocked by bug 167767

Eric Carlson

Comment 11 2017-02-03 08:34:55 PST

Created attachment 300535 [details] Updated patch.

WebKit Commit Bot

Comment 12 2017-02-03 09:12:43 PST

Comment on attachment 300535 [details] Updated patch. Clearing flags on attachment: 300535 Committed r211634: <http://trac.webkit.org/changeset/211634>

WebKit Commit Bot

Comment 13 2017-02-03 09:12:48 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.