Bug 167739 – [Mac] Add classes to manage audio samples

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Add classes to manage audio samples

[Eric Carlson]

Created attachment 300423 [details]
Proposed patch

[WebKit Commit Bot]

Attachment 300423 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/mac/AudioSampleBufferList.h:50:  The parameter name "format" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 300425 [details]
Updated patch

[Jer Noble]

Comment on attachment 300425 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300425&action=review

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:135
> +        kern_return_t kr = mach_timebase_info(&timebaseInfo);
> +        frequency = 1e-9 * static_cast<double>(timebaseInfo.numer) / static_cast<double>(timebaseInfo.denom);

This could use an explanatory comment.

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:162
> +            m_inputSampleOffset = toMediaTime(CMTimeConvertScale(toCMTime(m_inputSampleOffset), sampleTime.timeScale(), kCMTimeRoundingMethod_Default));

Please add a fixme comment about improving MediaTime to add this kind of rounding parameter functionality.

> Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:183
> +

Space.

[Eric Carlson]

Created attachment 300429 [details]
Patch for landing.

[WebKit Commit Bot]

Attachment 300429 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/mac/AudioSampleDataSource.cpp:162:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

Created attachment 300443 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 300443 [details]
Patch for landing.

Clearing flags on attachment: 300443

Committed r211596: <http://trac.webkit.org/changeset/211596>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 167767

[Eric Carlson]

Created attachment 300535 [details]
Updated patch.

[WebKit Commit Bot]

Comment on attachment 300535 [details]
Updated patch.

Clearing flags on attachment: 300535

Committed r211634: <http://trac.webkit.org/changeset/211634>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.