Bug 167719
| Summary: | ScriptDebugServer::sourceParsed takes a long time when running the sampling profiler | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> |
| Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | inspector-bugzilla-changes, joepeck |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Keith Miller
I noticed this when running the sampling profiler for C code on JSBench amazon/safari.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Joseph Pecoraro
I had a patch a while back that moved this line detection to the parser. However the frontend only treats \n as a newline and the parser treats \r\n and friends, so they differed. I agree this loop entirely through the source is not good and should be eliminated.