Bug 167710

Summary: [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch wenson_hsieh: review+

Simon Fraser (smfr)
Reported 2017-02-01 14:32:38 PST
[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
Attachments
Patch (12.08 KB, patch)
2017-02-01 14:37 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2017-02-01 14:37:32 PST
Created attachment 300355 [details] Patch
Simon Fraser (smfr)
Comment 2 2017-02-01 14:37:55 PST
rdar://problem/30100286
Wenson Hsieh
Comment 3 2017-02-01 15:15:50 PST
Comment on attachment 300355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300355&action=review > Source/WebKit2/ChangeLog:13 > += Stray "=" here > Source/WebKit2/UIProcess/ios/WKContentView.mm:379 > + CGRect inputViewContentBounds = [self.window convertRect:inputViewBounds toView:self]; Let's address this separately. It looks like this conversion breaks the behavior where fixed inputs dock to the visible content rect accounting for keyboard bounds.
Simon Fraser (smfr)
Comment 4 2017-02-01 17:15:00 PST
https://trac.webkit.org/r211541
Note You need to log in before you can comment on or make changes to this bug.