Bug 167710

Summary:

[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, thorton, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+

Description Simon Fraser (smfr) 2017-02-01 14:32:38 PST

[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible

Comment 1 Simon Fraser (smfr) 2017-02-01 14:37:32 PST

Created attachment 300355 [details]
Patch

Comment 2 Simon Fraser (smfr) 2017-02-01 14:37:55 PST

rdar://problem/30100286

Comment 3 Wenson Hsieh 2017-02-01 15:15:50 PST

Comment on attachment 300355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300355&action=review

> Source/WebKit2/ChangeLog:13
> +=

Stray "=" here

> Source/WebKit2/UIProcess/ios/WKContentView.mm:379
> +        CGRect inputViewContentBounds = [self.window convertRect:inputViewBounds toView:self];

Let's address this separately. It looks like this conversion breaks the behavior where fixed inputs dock to the visible content rect accounting for keyboard bounds.

Comment 4 Simon Fraser (smfr) 2017-02-01 17:15:00 PST

https://trac.webkit.org/r211541