Bug 167684

Summary: ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebKit Misc.Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, joepeck, mitz
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix mitz: review+

Description Joseph Pecoraro 2017-01-31 21:12:08 PST 
When building for iOS I see a linker warning:

ld: warning: instance method '_setAutofilled:' in category from /Build/WebKit.build/Release-iphoneos/WebKitLegacy.build/Objects-normal/arm64/DOMHTML.o conflicts with same method from another category

It looks like the same DOMHTMLInputElement extension appears in two places. Lets unify.
Comment 1 Joseph Pecoraro 2017-01-31 21:20:16 PST 
Created attachment 300298 [details]
[PATCH] Proposed Fix
Comment 2 mitz 2017-01-31 21:26:13 PST 
Comment on attachment 300298 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=300298&action=review

> Source/WebKit/mac/DOM/DOMPrivate.h:103
>  - (BOOL)_isTextField;

You should update the comment above, because this isn’t used by Safari anymore.
Comment 3 Joseph Pecoraro 2017-01-31 21:36:27 PST 
<https://trac.webkit.org/changeset/211468>