Summary: | [WebRTC][WebKit2] Support expanding the sandbox to allow microphone access at process launch | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 124288 | ||||||||
Attachments: |
|
Description
Brent Fulgham
2017-01-31 15:14:17 PST
Created attachment 300269 [details]
Patch
Comment on attachment 300269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300269&action=review We definitely need this, but don't we also need to call SandboxExtension::create and consume and revoke it? > Source/WebKit2/UIProcess/WebProcessPool.cpp:579 > + // FIXME: Remove this and related parameter when <rdar://problem/29448368> is fixed. I don't think we need this comment. (In reply to comment #3) > Comment on attachment 300269 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300269&action=review > > We definitely need this, but don't we also need to call > SandboxExtension::create and consume and revoke it? Isn't that handled by the SandboxExtension::consumePermanently(...) call we make in WebProcessCocoa? SandboxExtension::createHandleForGenericExtension calls into WKSandboxExtensionCreate. SandboxExtension::consumePermanently calls WKSandboxExtensionConsume and WKSandboxExtensionDestroy internally. Comment on attachment 300269 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300269&action=review > Source/WebKit2/UIProcess/WebProcessPool.cpp:578 > +#if ENABLE(WEB_RTC) This should probably be ENABLE(MEDIA_STREAM) and mediaStreamEnabled() Created attachment 300285 [details]
Patch
Comment on attachment 300285 [details] Patch Clearing flags on attachment: 300285 Committed r211470: <http://trac.webkit.org/changeset/211470> All reviewed patches have been landed. Closing bug. |