| Summary: | Make DumpRenderTree not crash | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Megan Gardner
2017-01-31 14:32:45 PST
Created attachment 300262 [details]
Patch
Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/ChangeLog:7 > + DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. > + So we're making sure it can do that without crashing. The tests won't work, but we won't crash. It would be nice if you explained the crash. Something like "We were using RunLoop::main().dispatch(), but this crashed because initBlah was never called so the global foo pointer was null. Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:47 > +#if PLATFORM(IOS) This should be in its own block at the bottom of the includes, not here. Fixed the windows error. Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:2414 > +#if !PLATFORM(IOS) We normally prefer to have iOS codego first. |