Bug 167633

Summary:

Performance Timeline: Prepare for Worker support

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

WebCore Misc.

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, commit-queue, dbates, esprehn+autocc, japhet, joepeck, kondapallykalyan, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none
[PATCH] Proposed Fix	rniwa: review+
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
[PATCH] For Bots	none

Description Joseph Pecoraro 2017-01-31 00:04:04 PST

Summary:
Performance Timeline: Prepare for Worker support

Remove Document / Frame references in Performance.

We will move to ScriptExecutionContext to support Document/WorkerGlobalScope.

And Performance can be given a timeOrigin value instead of looking it up through the Document.

Comment 1 Joseph Pecoraro 2017-01-31 00:08:45 PST

Created attachment 300193 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2017-01-31 00:11:21 PST

Attachment 300193 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Joseph Pecoraro 2017-01-31 00:37:53 PST

Created attachment 300195 [details]
[PATCH] Proposed Fix

I'm 0 for 2 on merge conflicts today! Lets try this one.

Comment 4 WebKit Commit Bot 2017-01-31 00:39:05 PST

Attachment 300195 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Build Bot 2017-01-31 04:05:02 PST

Comment on attachment 300195 [details]
[PATCH] Proposed Fix

Attachment 300195 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2978790

New failing tests:
css3/filters/backdrop/dynamic-with-clip-path.html

Comment 6 Build Bot 2017-01-31 04:05:06 PST

Created attachment 300201 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

Comment 7 Joseph Pecoraro 2017-01-31 21:08:10 PST

Comment on attachment 300201 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

> New failing tests:
> css3/filters/backdrop/dynamic-with-clip-path.html

This failure is unrelated.

Comment 8 Joseph Pecoraro 2017-01-31 21:08:37 PST

Ping for reviewers! This blocks the next patch which is adding Performance APIs to Workers.

Comment 9 Ryosuke Niwa 2017-01-31 21:59:10 PST

Comment on attachment 300195 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=300195&action=review

> Source/WebCore/page/Performance.cpp:91
> +

Please assert that we're in the main thread here.

Comment 10 Joseph Pecoraro 2017-02-01 13:48:17 PST

Created attachment 300351 [details]
[PATCH] For Bots

Comment 11 WebKit Commit Bot 2017-02-01 13:50:05 PST

Attachment 300351 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 12 Joseph Pecoraro 2017-02-01 14:14:11 PST

<https://trac.webkit.org/changeset/211527>