Bug 167603

Summary:

Drop legacy Attributes.isId attribute

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, cdumez, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Chris Dumez

Reported 2017-01-30 13:59:50 PST

Drop legacy Attributes.isId attribute. This attribute is not in the specification: - https://dom.spec.whatwg.org/#interface-attr Both Firefox and Chrome currently do not expose this attribute.

Attachments
Patch (16.59 KB, patch) 2017-01-30 14:38 PST, Chris Dumez	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-01-30 14:38:07 PST

Created attachment 300144 [details] Patch

WebKit Commit Bot

Comment 2 2017-01-30 16:23:51 PST

Comment on attachment 300144 [details] Patch Clearing flags on attachment: 300144 Committed r211395: <http://trac.webkit.org/changeset/211395>

WebKit Commit Bot

Comment 3 2017-01-30 16:23:57 PST

All reviewed patches have been landed. Closing bug.

Daniel Bates

Comment 4 2017-01-30 18:10:36 PST

Comment on attachment 300144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300144&action=review > LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml:-28 > - xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid04.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()"> Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid04.js? > LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml:-28 > - xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid05.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()"> Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid05.js?

Chris Dumez

Comment 5 2017-01-30 18:38:32 PST

(In reply to comment #4) > Comment on attachment 300144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300144&action=review > > > LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml:-28 > > - xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid04.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()"> > > Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid04.js? > > > LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml:-28 > > - xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid05.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()"> > > Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid05.js? Done in <http://trac.webkit.org/changeset/211400>. Thanks.

Note You need to log in before you can comment on or make changes to this bug.