Summary: | JSDOMBinding is too big. Split it up! | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, darin, joepeck, ossy | ||||||||||
Priority: | P2 | ||||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Sam Weinig
2017-01-30 13:23:12 PST
Created attachment 300138 [details]
Patch
Attachment 300138 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 3 in 45 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 300154 [details]
Patch
Attachment 300154 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 3 in 47 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 300156 [details]
Patch
Attachment 300156 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 3 in 49 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 300166 [details]
Patch
Attachment 300166 [details] did not pass style-queue:
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184: This { should be at the end of the previous line [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 2 in 80 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r211403: <http://trac.webkit.org/changeset/211403> Awesome! (In reply to comment #9) > Committed r211403: <http://trac.webkit.org/changeset/211403> It broke the Apple Mac cmake build, see https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11660 for details. buildfix landed in https://trac.webkit.org/changeset/211476 |