Bug 167598

Summary: Clean up accessibility & animations tests to stop calling testRunner.waitUntilDone() twice
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, ap, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, lforschler, mario, ryanhaddad, samuel_white
Priority: P2    
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156133    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2017-01-30 11:10:48 PST
The patch for Bug 156133 shows that testRunner.waitUntilDone() is called multiple times when running some of the tests in LayoutTests/accessibility and LayoutTests/animations. While calling waitUntilDone() twice in a row doesn't cause any issues in practice, it prevents the patch in Bug 156133 from landing, which would enforce more correct test behavior (and hopefully prevent flaky tests from landing in the tree in the future).
Attachments
Patch v1 (24.85 KB, patch)
2017-01-30 11:47 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2017-01-30 11:47:34 PST
Created attachment 300131 [details] Patch v1
Alexey Proskuryakov
Comment 2 2017-01-30 11:50:48 PST
Comment on attachment 300131 [details] Patch v1 rs=me pending EWS
WebKit Commit Bot
Comment 3 2017-02-02 10:56:50 PST
Comment on attachment 300131 [details] Patch v1 Clearing flags on attachment: 300131 Committed r211573: <http://trac.webkit.org/changeset/211573>
WebKit Commit Bot
Comment 4 2017-02-02 10:56:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.