Bug 167598

Summary: Clean up accessibility & animations tests to stop calling testRunner.waitUntilDone() twice
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Severity: Normal CC: aboxhall, apinheiro, ap, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, lforschler, mario, ryanhaddad, samuel_white
Priority: P2    
Version: Safari 10   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 156133    
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2017-01-30 11:10:48 PST
The patch for Bug 156133 shows that testRunner.waitUntilDone() is called multiple times when running some of the tests in LayoutTests/accessibility and LayoutTests/animations.

While calling waitUntilDone() twice in a row doesn't cause any issues in practice, it prevents the patch in Bug 156133 from landing, which would enforce more correct test behavior (and hopefully prevent flaky tests from landing in the tree in the future).
Comment 1 David Kilzer (:ddkilzer) 2017-01-30 11:47:34 PST
Created attachment 300131 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2017-01-30 11:50:48 PST
Comment on attachment 300131 [details]
Patch v1

rs=me pending EWS
Comment 3 WebKit Commit Bot 2017-02-02 10:56:50 PST
Comment on attachment 300131 [details]
Patch v1

Clearing flags on attachment: 300131

Committed r211573: <http://trac.webkit.org/changeset/211573>
Comment 4 WebKit Commit Bot 2017-02-02 10:56:57 PST
All reviewed patches have been landed.  Closing bug.