Bug 167558

Summary: AX: enable search predication for iOS
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, commit-queue, dmazzoni, jcraig, jdiggs, mario, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

chris fleizach
Reported 2017-01-29 01:25:11 PST
The searching mechanism we use on macOS should be available on iOS
Attachments
patch (34.70 KB, patch)
2017-01-30 12:20 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (58.92 KB, patch)
2017-01-30 12:21 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (58.97 KB, patch)
2017-01-30 12:24 PST, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-01-29 01:25:26 PST
<rdar://problem/30251367>
chris fleizach
Comment 2 2017-01-30 12:20:58 PST
Created attachment 300132 [details] patch
chris fleizach
Comment 3 2017-01-30 12:21:48 PST
Created attachment 300133 [details] patch
WebKit Commit Bot
Comment 4 2017-01-30 12:22:51 PST
Attachment 300133 [details] did not pass style-queue: ERROR: Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:74: An else should appear on the same line as the preceding } [whitespace/newline] [4] ERROR: Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:51: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:34: Bad include order. Mixing system and custom headers. [build/include_order] [4] ERROR: Tools/DumpRenderTree/mac/AccessibilityCommonMac.h:49: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Tools/DumpRenderTree/mac/AccessibilityCommonMac.mm:72: An else should appear on the same line as the preceding } [whitespace/newline] [4] Total errors found: 5 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
chris fleizach
Comment 5 2017-01-30 12:24:56 PST
Created attachment 300134 [details] patch
WebKit Commit Bot
Comment 6 2017-01-31 00:09:13 PST
Comment on attachment 300134 [details] patch Clearing flags on attachment: 300134 Committed r211411: <http://trac.webkit.org/changeset/211411>
WebKit Commit Bot
Comment 7 2017-01-31 00:09:17 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.