Bug 167522

Summary:

JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<>

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

WebCore JavaScript

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

msaboff, rniwa

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	msaboff: review-
Patch	fpizlo: review+

Description Filip Pizlo 2017-01-27 11:58:33 PST

Patch forthcoming.

Comment 1 Filip Pizlo 2017-01-27 12:02:33 PST

Created attachment 299949 [details]
the patch

Comment 2 Filip Pizlo 2017-01-27 12:02:56 PST

Ryosuke: I doubt this is the right fix.  Do you know what's going on here?

Comment 3 Michael Saboff 2017-01-27 13:43:39 PST

I talked with Ryosuke and have a fix that he agrees with.

Comment 4 Michael Saboff 2017-01-27 13:55:19 PST

<rdar://problem/30240378>

Comment 5 Michael Saboff 2017-01-27 14:04:39 PST

Created attachment 299958 [details]
Patch

Comment 6 Michael Saboff 2017-01-27 16:04:55 PST

Committed r211309: <http://trac.webkit.org/changeset/211309>