Bug 167522

Summary: JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<>
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: WebCore JavaScriptAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: msaboff, rniwa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
msaboff: review-
Patch fpizlo: review+

Filip Pizlo
Reported 2017-01-27 11:58:33 PST
Patch forthcoming.
Attachments
the patch (1.56 KB, patch)
2017-01-27 12:02 PST, Filip Pizlo 		msaboff: review-
DetailsFormatted DiffDiff
Patch (3.33 KB, patch)
2017-01-27 14:04 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-01-27 12:02:33 PST
Created attachment 299949 [details] the patch
Filip Pizlo
Comment 2 2017-01-27 12:02:56 PST
Ryosuke: I doubt this is the right fix. Do you know what's going on here?
Michael Saboff
Comment 3 2017-01-27 13:43:39 PST
I talked with Ryosuke and have a fix that he agrees with.
Michael Saboff
Comment 4 2017-01-27 13:55:19 PST
<rdar://problem/30240378>
Michael Saboff
Comment 5 2017-01-27 14:04:39 PST
Created attachment 299958 [details] Patch
Michael Saboff
Comment 6 2017-01-27 16:04:55 PST
Committed r211309: <http://trac.webkit.org/changeset/211309>
Note You need to log in before you can comment on or make changes to this bug.