Bug 167519 – Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line

This is ugly and annoying!

[Joseph Pecoraro]

Created attachment 299947 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 299947 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299947&action=review

> Tools/QueueStatusServer/templates/statusbubble.html:57
> +    var parentContainer = bubbleContainer.parentElement;

Please note that I had no way of testing this code with any fake bugzilla instance. I just paused here in inspector and did these operations to ensure they worked for me. If someone has a way to test this for real, please let me know!

[Alexey Proskuryakov]

This is surprising, why do they wrap for you, but not for me? Pretty sure I fixed something like this in the past. 

Could you add a screenshot?

Longer term, we'll be adding more bubbles, so they will no longer fit in a reasonably sized window.

[Alexey Proskuryakov]

Comment on attachment 299947 [details]
[PATCH] Proposed Fix

Now that I'm back at a Mac, I see that it actually wraps for me too. But is there enough space to let it grow horizontally indeed? The layout gets really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the current 450px looks bad on an iPhone.

I agree that the review bar needs it layout to be improved.

[Ryosuke Niwa]

Comment on attachment 299947 [details]
[PATCH] Proposed Fix

Talked in person.

[Ryosuke Niwa]

(In reply to comment #4)
> Comment on attachment 299947 [details]
> [PATCH] Proposed Fix
> 
> Now that I'm back at a Mac, I see that it actually wraps for me too. But is
> there enough space to let it grow horizontally indeed? The layout gets
> really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the
> current 450px looks bad on an iPhone.

Yeah, I think that's a good long term consideration. For now, increasing the width of the bubbles seems like a good short term solution.

[Joseph Pecoraro]

(In reply to comment #4)
> Comment on attachment 299947 [details]
> [PATCH] Proposed Fix
> 
> Now that I'm back at a Mac, I see that it actually wraps for me too. But is
> there enough space to let it grow horizontally indeed? The layout gets
> really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the
> current 450px looks bad on an iPhone.

The 1000px should only be for measuring. It then gets immediately set back to what it was before.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/211331>