| Summary: | Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, ddkilzer, joepeck, lforschler, rniwa, simon.fraser | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Joseph Pecoraro
2017-01-27 11:25:44 PST
Created attachment 299947 [details]
[PATCH] Proposed Fix
Comment on attachment 299947 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299947&action=review > Tools/QueueStatusServer/templates/statusbubble.html:57 > + var parentContainer = bubbleContainer.parentElement; Please note that I had no way of testing this code with any fake bugzilla instance. I just paused here in inspector and did these operations to ensure they worked for me. If someone has a way to test this for real, please let me know! This is surprising, why do they wrap for you, but not for me? Pretty sure I fixed something like this in the past. Could you add a screenshot? Longer term, we'll be adding more bubbles, so they will no longer fit in a reasonably sized window. Comment on attachment 299947 [details]
[PATCH] Proposed Fix
Now that I'm back at a Mac, I see that it actually wraps for me too. But is there enough space to let it grow horizontally indeed? The layout gets really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the current 450px looks bad on an iPhone.
I agree that the review bar needs it layout to be improved.
Comment on attachment 299947 [details]
[PATCH] Proposed Fix
Talked in person.
(In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. Yeah, I think that's a good long term consideration. For now, increasing the width of the bubbles seems like a good short term solution. (In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. The 1000px should only be for measuring. It then gets immediately set back to what it was before. |